Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkwave: build with gtk3 #75657

Merged
merged 1 commit into from Dec 15, 2019
Merged

gtkwave: build with gtk3 #75657

merged 1 commit into from Dec 15, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 14, 2019

gtkwave ships a gtk3 flavour on sourceforge. let's use that one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice

@ofborg ofborg bot requested a review from thoughtpolice December 14, 2019 18:22
worldofpeace
worldofpeace suggested changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://nixos.org/nixpkgs/manual/#sec-language-gnome.
You need to add wrapGAppsHook and glib.

@flokli
gtkwave: build with gtk3
ac1a5ac 
gtkwave ships a gtk3 flavour on sourceforge. let's use that one.
worldofpeace
worldofpeace approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@flokli flokli merged commit 0380ed2 into NixOS:master Dec 15, 2019
@flokli flokli deleted the gtkwave-gtk3 branch December 15, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @worldofpeace