-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the ReadFromMessage method of the integrators to be static #2404
Conversation
#define PRINCIPIA_CASE_SLMS(kind, method, action) \ | ||
case serialization::FixedStepSizeIntegrator::kind: { \ | ||
action(method); \ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if action
does not return or break, this is a fallthrough. Maybe break
? Perhaps even without a semicolon, so as to require a semicolon from the caller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a break;
. I hope that it won't be detected as dead code by some smart compiler.
Let's not play games with semicolons, it seems odd to force the macro to include a semicolon.
This will be necessary to be able to SFINAE out the ReadFromMessage for types that depend on non-serializable frames: no SFINAE on virtual methods.