Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpd: fix-build on darwin #75639

Merged
merged 1 commit into from Dec 14, 2019
Merged

mpd: fix-build on darwin #75639

merged 1 commit into from Dec 14, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 14, 2019

Motivation for this change

See: https://hydra.nixos.org/build/108094706

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 14, 2019
@ofborg ofborg bot requested review from astsmtl, ehmry, fpletz and tobim December 14, 2019 04:19
tobim
tobim approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonringer
Copy link
Contributor

@GrahamcOfBorg build mpd

jonringer
jonringer approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
didn't test, but now builds on darwin
no changes to linux

@jonringer jonringer merged commit c7f8538 into NixOS:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@jonringer jonringer jonringer approved these changes

@astsmtl astsmtl Awaiting requested review from astsmtl

@ehmry ehmry Awaiting requested review from ehmry

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @jonringer @tobim