Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavproxy: init at 1.8.17 #75640

Merged
merged 2 commits into from Dec 14, 2019
Merged

mavproxy: init at 1.8.17 #75640

merged 2 commits into from Dec 14, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

MAVProxy is a command line ground control station (GCS) for drones using the standard MAVLink protocol (ie. ArduPilot, PX4). Some GUI GCSs are already included in nixpkgs (QGroundControl, apmplanner2), but MAVProxy includes move development focused functionality that is required for certain use-cases, such as performing software-in-the-loop simulation with ArduPilot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @wucke13 because you have worked on apmplanner2 and QGroundControl, so might be interested in this package

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
mavproxy executable shows usagea

[7 built, 2 copied (83.3 MiB), 15.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75640
4 package were built:
mavproxy python27Packages.pymavlink python37Packages.pymavlink python38Packages.pymavlink

@jonringer
Copy link
Contributor

@GrahamcOfBorg build mavproxy python27Packages.pymavlink python37Packages.pymavlink python38Packages.pymavlink

@jonringer jonringer merged commit bd9549b into NixOS:master Dec 14, 2019
@lopsided98 lopsided98 deleted the mavproxy-init branch December 15, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants