Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-credential-helpers: init at 0.6.3 #75728

Merged
merged 1 commit into from Dec 20, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 16, 2019

Motivation for this change

Closes #75726

I could not build docker-credential-pass on darwin, I'll try again once docker/docker-credential-helpers#169 is merged
cc: @NilsIrl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@NilsIrl
Copy link
Member

NilsIrl commented Dec 16, 2019

I'll try to test this as soon as possible

@marsam marsam merged commit a85c8d8 into NixOS:master Dec 20, 2019
@marsam marsam deleted the add-docker-credential-helpers branch December 20, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging request: docker-credential-helpers
2 participants