Version of OpenTTD

As of master version 2019-12-07 (32-bit Win7)

Expected result

• Starting a new map from the title screen NewGRF window reloads the NewGRFs once.
• Clicking "Apply Changes" in the title screen NewGRF window then closing said window reloads the NewGRFs once.

Actual result

• Starting a new map from the title screen NewGRF window reloads the NewGRFs twice, making it take twice as long to start a new map if you change NewGRFs compared to if you don't change NewGRFs.
• Clicking "Apply Changes" in the title screen NewGRF window then closing said window reloads the NewGRFs twice.

If you are testing 60 different NewGRF combinations and it takes 10 seconds to reload the NewGRFs on average, that's an extra 10+ minutes of waiting compared to if you didn't have to reload the NewGRFs a second time every time.

Steps to reproduce

(Double reload when starting new map from title screen NewGRF window)

1. Enter title screen.
2. Go into the NewGRF window.
3. Pull down the console and type newmap or newgame to start a new map.
4. The game reloads the NewGRFs.
5. The button press beep sound plays.
6. The game reloads the NewGRFs again.
7. The new map is generated.

(Double reload when hitting "Apply Changes" in title screen NewGRF window then exiting out of it)

1. Enter title screen.
2. Go into the NewGRF window.
3. Click "Apply Changes".
4. The game reloads the NewGRFs.
5. Close the NewGRF window.
6. The game reloads the NewGRFs again.