Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: fix ip46tables invocation in nat #75681

Merged
merged 1 commit into from Dec 15, 2019
Merged

nixos: fix ip46tables invocation in nat #75681

merged 1 commit into from Dec 15, 2019

Conversation

lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Dec 15, 2019 •
edited

Motivation for this change

This fixes the current failure in Hydra that was introduced in 3e792fb.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cleverca22 @volth @worldofpeace

@worldofpeace
Copy link
Contributor

@lovesegfault I think you meant to ping @cleverca22 😄

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg test nat.standalone

@lovesegfault
Copy link
Member Author

@worldofpeace Oops, yes 😆. Fixed :)

@worldofpeace
Copy link
Contributor

Reported failing test is https://hydra.nixos.org/build/108241462

@lovesegfault
Copy link
Member Author

@worldofpeace SHIP IT

worldofpeace
worldofpeace approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace
Copy link
Contributor

Going quick because it's a channel blocker.

@worldofpeace worldofpeace merged commit 18571d6 into NixOS:master Dec 15, 2019
@lovesegfault lovesegfault deleted the nixos-fix-nat branch April 7, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovesegfault @worldofpeace