Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-libre_latest: update automatically; fix build #75741

Merged
merged 3 commits into from Dec 16, 2019
Merged

linux-libre_latest: update automatically; fix build #75741

merged 3 commits into from Dec 16, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Dec 16, 2019 •
edited

Motivation for this change

Alternative to #74726.

This should mean that Linux-libre is updated whenever @NeQuissimus updates the kernel, AND whenever update scripts are run — I think r-ryantm does this?

Between these two scenarios, I’m hoping this should be run often enough that the libre kernels almost always build, even when new kernel series are added in Nixpkgs before Linux-libre supports them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais changed the title linux-libre: update automatically; fix build linux-libre_latest: update automatically; fix build Dec 16, 2019
@alyssais alyssais mentioned this pull request Dec 16, 2019
Closed
10 tasks
@worldofpeace
Copy link
Contributor

AND whenever update scripts are run — I think r-ryantm does this?

I believe this is handled completely differently. These updates scripts are usually only ran by humans.

@alyssais
Copy link
Member Author

AND whenever update scripts are run — I think r-ryantm does this?

I believe this is handled completely differently. These updates scripts are usually only ran by humans.

Oh, you’re right. :(

@alyssais
Copy link
Member Author

I think this is still worth a shot. By the time a new kernel series is in Nixpkgs, it should already be supported by Linux-libre I think because they start work on new kernels during the RCs.

@worldofpeace
Copy link
Contributor

It seems good to me @alyssais, but I'm not sure about adding to pkgs/os-specific/linux/kernel/update.sh. Maintainers of kernel have to be ok with picking up this one, as it makes it update the libre one.

@worldofpeace
Copy link
Contributor

Also ❤️ for the kernel in NixOS being integrated so expectantly @NeQuissimus.

@alyssais
Copy link
Member Author

Maintainers of kernel have to be ok with picking up this one, as it makes it update the libre one.

Absolutely, hence the request for a review from @NeQuissimus. fwiw, I don’t think the kernel maintainers have any responsibility for ensuring Linux-libre build after updating it — this is just something that needs to be done at the same time. The alternative would be I write a bot to do it, which would just be more annoying for everyone I suspect.

@alyssais
linux/update.sh: update linux-libre too
7bc3771 
update-libre.sh doesn't commit by default so that it can be used as an
updateScript, where I don't think auto-committing is the norm.

The generated commit messages say "linux-libre_latest" rather than
"linux-libre", because even though linux-libre will also be rebuilt,
it's linux-libre_latest that is more likely to need it.
@alyssais
linux-libre: set update-libre.sh as update script
0b39d87 
This doesn't actually update the kernel, just the linux-libre
deblobbing scripts, but it should mean that automatic updaters keep
the deblobbing scripts up to date.  So even if deblobbing scripts for
a new kernel version are not available immediately after release, they
should be updated automatically soon enough once available.
@alyssais
linux-libre_latest: 16794 -> 17112
36dcc8f
@NeQuissimus
Copy link
Member

I'll put it this way:
I can run the script, for sure. This will update the kernel. But the build itself I cannot run, it is far more time-intensive than the vanilla kernels.
So if the libre kernel breaks from my commits, I will not be able to fix it.
If everybody is OK with that, let's do this.

@alyssais
Copy link
Member Author

That sounds good to me.

@alyssais alyssais merged commit 987a59e into NixOS:master Dec 16, 2019
@alyssais alyssais deleted the linux-libre-update branch December 16, 2019 16:30
@alyssais
Copy link
Member Author

Pushed a tiny fixup I noticed just after merging: d770ae1

@alyssais
Copy link
Member Author

alyssais commented Dec 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @worldofpeace @NeQuissimus