Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hqemu: init at 2.5.2 #75705

Closed
wants to merge 1 commit into from
Closed

hqemu: init at 2.5.2 #75705

wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 15, 2019

Motivation for this change

hqemu (http://csl.iis.sinica.edu.tw/hqemu/) is an interesting research project that grafts LLVM on to qemu's TCG binary translation, allowing it to optimize hotspots. I've managed to get some pretty good results from it, tripling execution speeds in some of my tests.

Package is heavily based on the qemu one, with some features removed and disabled for darwin - I get the feeling linux is the only host that has ever seen any attention, and my brief attempts at getting it to build on macos yielded nothing but pain.

Also note it has knownVulnerabilities set because it's not as though this is a security-maintained application, so isn't really appropriate for production use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

heavily based on existing qemu package
@typetetris
Copy link
Contributor

Looks like a qemu derivative work, which would be GPL licensed. Don't know if the content of COPYRIGHT in the tarball is compatible with GPL.

@risicle
Copy link
Contributor Author

risicle commented Jul 19, 2020

That's a very good point - hadn't noticed that. Do we have a "license: unclear"?

(also forgot this had approval and now I have committer permissions I could technically merge this myself, but won't until we have some clarity)

@typetetris
Copy link
Contributor

I don't think there is license: unclear. Maybe try to get the upstream authors to use something more clear?

@risicle
Copy link
Contributor Author

risicle commented Jul 20, 2020

The upstream project is basically an academic paper and it doesn't seem to really be maintained anymore. The license sounds like one of those "university ip policy" disclaimers and I don't see much hope in getting clarity from "upstream".

@prusnak
Copy link
Member

prusnak commented Dec 3, 2020

@risicle do you still want to get this in?

@risicle
Copy link
Contributor Author

risicle commented Dec 3, 2020

Well, the latest status is I'm unclear hqemu's license

@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
@doronbehar
Copy link
Contributor

I think it'd be OK to add this package to NixOS, with the unfree license, if upstream doesn't say differently.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg eval

else null)
}:

with stdenv.lib;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with stdenv.lib;
with lib;

qemu-system-i386 = "bin/qemu-system-i386";
};

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@risicle
Copy link
Contributor Author

risicle commented Jun 3, 2021

TBH I think I'm going to close this PR because I don't want to have to maintain this, or even keep its list of known vulnerabilities up to date. I won't delete the branch, because this at least serves a purpose as a piece of software archaeology - a project that's tricky to build that at least now has a "known good" point in time that it can be reliably built.

@stale
Copy link

stale bot commented Jan 9, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022
@onny onny marked this pull request as draft September 7, 2022 06:22
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 7, 2022
@Mic92
Copy link
Member

Mic92 commented Dec 18, 2022

Closing because of lack of activity from the author. Please re-open if you plan to work on this.

@Mic92 Mic92 closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants