Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pdfminer: 20181108 -> 20191020 #75725

Merged
merged 5 commits into from Dec 16, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 15, 2019

Motivation for this change

Changelog: https://github.com/pdfminer/pdfminer.six/releases/tag/20191020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a regression in ocrmpdf, since it's outside python-modules you can either add an override to the python package set which freezes the version to the previous version of pdfminer, or overwrite the version bounds they specify in install_requires.

Bumping the ocrmypdf package may also work.

I just don't want to commit this while it may cause a regression.

warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/8hand4jsabyfw4y9sz2ng041hyyjpgbh-ocrmypdf-9.0.3.drv' failed with exit code 1; last 10 log lines:
  /build/source/dist /build/source
  Processing ./ocrmypdf-9.0.3-py35-none-any.whl
  Requirement already satisfied: reportlab>=3.3.0 in /nix/store/6724c2h0lzwy0w994kbmfszafp4h6mcd-python3.7-reportlab-3.5.32/lib/python3.7/site-packages (from ocrmypdf==9.0.3) (3.5.32)
  Requirement already satisfied: img2pdf<0.4,>=0.3.0 in /nix/store/f4s7323l8463k8gl39p0p1whxxvk31ly-img2pdf-0.3.3/lib/python3.7/site-packages (from ocrmypdf==9.0.3) (0.3.3)
  Requirement already satisfied: chardet<4,>=3.0.4 in /nix/store/xjs7jsal89nx0s8idwzxaa32j3x9475s-python3.7-chardet-3.0.4/lib/python3.7/site-packages (from ocrmypdf==9.0.3) (3.0.4)
  Requirement already satisfied: pikepdf<2,>=1.6.0 in /nix/store/xwl2p22v8i171aamnxx6h41267zcqwix-python3.7-pikepdf-1.8.0/lib/python3.7/site-packages (from ocrmypdf==9.0.3) (1.8.0)
  Requirement already satisfied: cffi>=1.9.1 in /nix/store/9kjhgqwv6pqalkcf2mg7y4x7b5r798yp-python3.7-cffi-1.13.2/lib/python3.7/site-packages (from ocrmypdf==9.0.3) (1.13.2)
  Requirement already satisfied: tqdm>=4 in /nix/store/c5gnlk3vv1dbpd65732fcsdizvx95kb5-python3.7-tqdm-4.36.1/lib/python3.7/site-packages (from ocrmypdf==9.0.3) (4.36.1)
  ERROR: Could not find a version that satisfies the requirement pdfminer.six==20181108 (from ocrmypdf==9.0.3) (from versions: none)
  ERROR: No matching distribution found for pdfminer.six==20181108 (from ocrmypdf==9.0.3)

@marsam
Copy link
Contributor Author

marsam commented Dec 16, 2019

good catch! I've bumped ocrmypdf

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[84 built (13 failed), 781 copied (2823.6 MiB), 926.4 MiB DL]
error: build of '/nix/store/qq5pvpfhyxag0fnr15vr92ymqyx3dnym-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75725
5 package are marked as broken and were skipped:
invoice2data python27Packages.baselines python37Packages.pyro-ppl python38Packages.pyro-ppl tahoe-lafs

12 package failed to build:
nrfutil python27Packages.magic-wormhole python27Packages.weboob python37Packages.baselines python37Packages.mesa python37Packages.starfish python37Packages.toggl-cli python38Packages.baselines python38Packages.salmon-mail python38Packages.spacy python38Packages.textacy python38Packages.toggl-cli

68 package were built:
apache-airflow backblaze-b2 conan deja-dup duplicity duply evdevremapkeys gmailieer gnome-keysign keepkey_agent kmymoney ledger_agent luigi magic-wormhole ocrmypdf papis python27Packages.papermill python27Packages.pdfminer python27Packages.pdfx python27Packages.proglog python27Packages.thinc python27Packages.tqdm python37Packages.accupy python37Packages.ansible-kernel python37Packages.ansible-runner python37Packages.libagent python37Packages.moviepy python37Packages.papermill python37Packages.parfive python37Packages.pdfminer python37Packages.pdfx python37Packages.perfplot python37Packages.pikepdf python37Packages.proglog python37Packages.pymc3 python37Packages.python-daemon python37Packages.salmon-mail python37Packages.spacy python37Packages.sunpy python37Packages.textacy python37Packages.thinc python37Packages.tqdm trezor_agent python37Packages.twine python37Packages.weboob python38Packages.accupy python38Packages.ansible-kernel python38Packages.ansible-runner python38Packages.keepkey_agent python38Packages.ledger_agent python38Packages.libagent python38Packages.magic-wormhole python38Packages.moviepy python38Packages.papermill python38Packages.papis python38Packages.parfive python38Packages.pdfminer python38Packages.pdfx python38Packages.perfplot python38Packages.pikepdf python38Packages.proglog python38Packages.python-daemon python38Packages.thinc python38Packages.tqdm python38Packages.trezor_agent python38Packages.twine python38Packages.weboob tinyprog

@jonringer jonringer merged commit 01956b5 into NixOS:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants