Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mypy: 0.740 -> 0.750 #75738

Merged
merged 2 commits into from Dec 18, 2019
Merged

python3Packages.mypy: 0.740 -> 0.750 #75738

merged 2 commits into from Dec 18, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019 •
edited

Motivation for this change

looking through @r-ryantm logs

Also refactored expression to follow ordering of most other python packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

python38Packages.pyls-mypy is failing due to upstream python3.8 issue, unrelated to PR

https://github.com/NixOS/nixpkgs/pull/75738
1 package failed to build:
python38Packages.pyls-mypy

18 package were built:
git-revise mypy nix-pin python37Packages.algebraic-data-types python37Packages.ics python37Packages.pyls-mypy python37Packages.pynamodb python37Packages.pytest-mypy python37Packages.tatsu python38Packages.algebraic-data-types python38Packages.git-revise python38Packages.ics python38Packages.mypy python38Packages.pynamodb python38Packages.pytest-mypy python38Packages.tatsu thonny zfs-replicate

@jonringer
python3Packages.mypy: 0.740 -> 0.750
3b3d392 
Also refactored expression to follow ordering of most other python packages
@ofborg ofborg bot requested review from martingms and LnL7 December 16, 2019 03:35
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build git-revise mypy nix-pin python37Packages.algebraic-data-types python37Packages.ics python37Packages.pyls-mypy python37Packages.pynamodb python37Packages.pytest-mypy python37Packages.tatsu python38Packages.algebraic-data-types python38Packages.git-revise python38Packages.ics python38Packages.mypy python38Packages.pynamodb python38Packages.pytest-mypy python38Packages.tatsu thonny zfs-replicate

@ofborg ofborg bot requested a review from primeos December 16, 2019 04:39
@primeos
Copy link
Member

primeos commented Dec 16, 2019

Thanks for fixing the ics build :)

@teto
Copy link
Member

teto commented Dec 18, 2019

python3.7-algebraic-data-types-0.1.1 looks like the culprit

@jonringer
Copy link
Contributor Author

failures are outside of this PR, in different packages

@jonringer jonringer merged commit 503ca8f into NixOS:master Dec 18, 2019
@jonringer jonringer deleted the bump-mypy branch January 6, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@martingms martingms Awaiting requested review from martingms

@LnL7 LnL7 Awaiting requested review from LnL7

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @primeos @teto