Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fadba09a8378
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ee88d4a71e54
Choose a head ref
  • 17 commits
  • 6 files changed
  • 1 contributor

Commits on Dec 14, 2019

  1. Big switches ahead.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    40f065e View commit details
  2. A case macro.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    60f7dcb View commit details
  3. Macros and compilation fixes.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    00e2c19 View commit details
  4. Copy the full SHA
    e9d3648 View commit details
  5. Still missing the SPRK.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    e8077a8 View commit details
  6. Move code out of the macros.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    889042a View commit details
  7. Copy the full SHA
    4f12939 View commit details
  8. Cleanup.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    44f30a8 View commit details
  9. Copy the full SHA
    e25e261 View commit details
  10. Extreme template porn.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    f5f50ea View commit details
  11. Cleanup.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    900a254 View commit details
  12. Template specialization.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    8791fab View commit details
  13. Cleanup.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    0dc24b7 View commit details
  14. After egg's review.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    c50da36 View commit details
  15. Fix compilation errors.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    c499b04 View commit details
  16. Lint.

    pleroy committed Dec 14, 2019
    Copy the full SHA
    8fd5398 View commit details
  17. Merge pull request #2404 from pleroy/IntegratorsRead

    Change the ReadFromMessage method of the integrators to be static
    pleroy authored Dec 14, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    ee88d4a View commit details
10 changes: 0 additions & 10 deletions integrators/integrators.hpp
Original file line number Diff line number Diff line change
@@ -114,16 +114,6 @@ class FixedStepSizeIntegrator : public Integrator<ODE_> {
serialization::FixedStepSizeIntegrator const& message);

protected:
// For convenience, deserialization is an instance member of the |Integrator|,
// not a static member of the |Instance|. Which makes sense if you see
// |Integrator| as a factory for |Instance|.
virtual not_null<std::unique_ptr<typename Integrator<ODE>::Instance>>
ReadFromMessage(
serialization::FixedStepSizeIntegratorInstance const& message,
IntegrationProblem<ODE> const& problem,
AppendState const& append_state,
Time const& step) const = 0;

FixedStepSizeIntegrator() = default;
};

Loading