Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and update vim plugins #75683

Closed
wants to merge 1 commit into from
Closed

Add and update vim plugins #75683

wants to merge 1 commit into from

Conversation

softinio
Copy link
Member

Motivation for this change
  • Added missing vim plugins
  • Auto generate script updated existing vim packages
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from jagajaga December 15, 2019 07:33
@jonringer
Copy link
Contributor

should be one commit for updating vim plugins, then one commit per package added

@softinio
Copy link
Member Author

This PR is one commit. Assume you want me to do a separate PR per vim plugin. So will close. And when I next get time will do that.

@softinio softinio closed this Dec 15, 2019
@softinio softinio deleted the add-new-vim-plugins-2 branch December 15, 2019 15:48
@jonringer
Copy link
Contributor

@softinio no, having a single PR is fine, it just needs to adhere to https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs

You should have one commit where you run the update script. Then a commit for each package you add. each plugin addition can be thought of a separate package

@softinio softinio mentioned this pull request Dec 16, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@softinio @jonringer