Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clj-kondo: 2019.11.07 -> 2019.12.14 #75733

Merged
merged 1 commit into from Dec 21, 2019
Merged

clj-kondo: 2019.11.07 -> 2019.12.14 #75733

merged 1 commit into from Dec 21, 2019

Conversation

ericdallo
Copy link
Member

Motivation for this change

Update clj-kondo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @BAndresen @jlesquembre

bennyandresen
bennyandresen approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@bennyandresen bennyandresen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlesquembre
Copy link
Member

@ericdallo changes look good, but could you squash your commits in only one?

@ericdallo
Copy link
Member Author

Yeah, sorry for that, done @jlesquembre

@ofborg ofborg bot requested a review from bennyandresen December 17, 2019 00:22
@jlesquembre
Copy link
Member

LGTM
thanks @ericdallo

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/80

@markuskowa markuskowa merged commit 40dd307 into NixOS:master Dec 21, 2019
@ericdallo ericdallo deleted the clj-kondo-update branch December 21, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre jlesquembre approved these changes

@bennyandresen bennyandresen Awaiting requested review from bennyandresen

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ericdallo @jlesquembre @nixos-discourse @bennyandresen @markuskowa