Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.weboob: add futures dependency #75746

Merged
merged 1 commit into from Dec 16, 2019
Merged

pythonPackages.weboob: add futures dependency #75746

merged 1 commit into from Dec 16, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019 •
edited

Motivation for this change

noticed it was broken reviewing #75725

also formatted the file

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75746
4 package were built:
kmymoney python27Packages.weboob python37Packages.weboob python38Packages.weboob

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.weboob

@teto
Copy link
Member

teto commented Dec 16, 2019

the failure looks unrelated, merging

@teto teto merged commit ac9d0cb into NixOS:master Dec 16, 2019
@jonringer jonringer deleted the fix-weboob branch December 16, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @teto