Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gym: disable due to missing dependencies #75749

Closed
wants to merge 1 commit into from
Closed

python3Packages.gym: disable due to missing dependencies #75749

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019 •
edited

Motivation for this change

tired of seeing the broken noise when reviewing other packages for the past few weeks. It's broken, and unless someone wants to package opencv-python, I'm disabling this

ERROR: Could not find a version that satisfies the requirement opencv-python (from gym==0.15.4) (from versions: none)
  ERROR: No matching distribution found for opencv-python (from gym==0.15.4)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor

marsam commented Dec 16, 2019

I was wondering, wouldn't be better to just to remove the python broken packages from nixpkgs? python-packages specifically has grown steadily; most of them lack of maintainers, and takes a lot of effort to maintain. cc: @FRidh

@jonringer
Copy link
Contributor Author

The other option would be to revert this, as it was done blindly during the great python3.8 mass-update
8ee4062

@marsam
Copy link
Contributor

marsam commented Dec 16, 2019

I personally prefer reverted it, with a comment; instead of keeping a broken package

@jonringer
Copy link
Contributor Author

closing in favor of reverting

@jonringer jonringer closed this Dec 16, 2019
@jonringer jonringer deleted the disable-gym branch December 16, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam