Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mesa: 0.8.6 -> unstable-2019-12-09 #75750

Merged
merged 1 commit into from Dec 16, 2019
Merged

python3Packages.mesa: 0.8.6 -> unstable-2019-12-09 #75750

merged 1 commit into from Dec 16, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019 •
edited

Motivation for this change

networkx 2.4 broke their api networkx/networkx#3750

the last official mesa release was so long ago that patches no longer cleanly apply

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

https://github.com/NixOS/nixpkgs/pull/75750
1 package were built:
python37Packages.mesa

@jonringer
python3Packages.mesa: 0.8.6 -> unstable-2019-12-09
563602a 
their last official release was so long ago that
patches no longer cleanly apply
@ofborg ofborg bot requested a review from dpaetzel December 16, 2019 07:34
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.mesa

dpaetzel
dpaetzel reviewed Dec 16, 2019
View reviewed changes
Copy link
Contributor

@dpaetzel dpaetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I tried running my models and they did as usual. Thank you!

@dpaetzel
Copy link
Contributor

dpaetzel commented Dec 16, 2019 •
edited

Short question on the side: Is there a way to directly test a library PR such as this using nix-review? Because with nix-review, I couldn't find a way to easily get a nix-shell for the python interpreter of python37.withPackages(ps: ps.mesa). (Instead, I did it manually.)

@jonringer
Copy link
Contributor Author

it's a bit of a hack, but I do

nix-shell --pure -p "with import ./nixpkgs {}; python3Packages.mesa"

that way, there's only one package, and it doesn't collide with the other packages that were built

@jonringer jonringer merged commit aea972a into NixOS:master Dec 16, 2019
@jonringer jonringer deleted the fix-python-mesa branch February 20, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpaetzel dpaetzel dpaetzel left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @dpaetzel