Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exa: apply patch to not panic on broken symlinks #75673

Merged
merged 1 commit into from Dec 15, 2019
Merged

exa: apply patch to not panic on broken symlinks #75673

merged 1 commit into from Dec 15, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 15, 2019

Currently, exa fails when being executed in a git repository with
symlinks pointing to a non-existing location.

This can happen quite often with garbage-collected result links, or in
bazel repositories.

A fix was PR'ed in September at ogham/exa#584,
but upstream seems to be not responding.

Let's apply this patch until there's a release containing the fixes.

Motivation for this change

I prefer directory listings over rust panics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@flokli
exa: apply patch to not panic on broken symlinks
d41dca2 
Currently, exa fails when being executed in a git repository with
symlinks pointing to a non-existing location.

This can happen quite often with garbage-collected result links, or in
bazel repositories.

A fix was PR'ed in September at ogham/exa#584,
but upstream seems to be not responding.

Let's apply this patch until there's a release containing the fixes.
@flokli flokli added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 15, 2019
@flokli flokli requested a review from andir December 15, 2019 01:23
andir
andir approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the very annoying crash for me! 👍

@andir andir merged commit 928bc00 into NixOS:master Dec 15, 2019
@flokli flokli deleted the exa-broken-symlinks branch December 15, 2019 01:29
@flokli
Copy link
Contributor Author

flokli commented Dec 15, 2019 •
edited

backported to 19.09 in d85e435.

@ofborg ofborg bot requested review from lilyball and globin December 15, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@lilyball lilyball Awaiting requested review from lilyball

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @andir