New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-shell: don't check for "nix-shell" in shebang script name #3269

Merged

edolstra merged 1 commit into NixOS:master from xzfc:nix-shell

Dec 14, 2019

Contributor

xzfc commented Dec 14, 2019

Fix bug: if the path to the nix-shell shebang script contains "nix-shell", it won't run properly.

$ cat a-script-that-should-be-run-in-nix-shell.sh
#! /usr/bin/env nix-shell
#! nix-shell -p hello -i sh
hello

$ ./a-script-that-should-be-run-in-nix-shell.sh
error: undefined variable 'hello' at /tmp/a-script-that-should-be-run-in-nix-shell.sh:3:1

$ mv a-script-that-should-be-run-in-nix-shell.sh a-script.sh

$ ./a-script.sh
Hello, world!

Probably this check was relevant when nix-build was a perl script (as perl handles argv differently than C++).


          nix-shell: don't check for "nix-shell" in shebang script name

a70706b

Member

zimbatm commented Dec 14, 2019

this would fix #3153

edolstra merged commit 8656a2d into NixOS:master

xzfc deleted the nix-shell branch

December 14, 2019 23:13

ldesgoui mentioned this pull request

Write Nix 2.4 release notes #4521

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment