Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xilinx-bootgen: init at 2019-10-23 #75722

Merged
merged 1 commit into from Dec 15, 2019
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 15, 2019

Motivation for this change

Being able to assemble boot.img files for XIlinx Zynq and ZU+ SoCs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

pkgs/tools/misc/xilinx-bootgen/default.nix Outdated Show resolved Hide resolved
@flokli flokli merged commit 39b20f0 into NixOS:master Dec 15, 2019
@flokli flokli deleted the xilinx-bootgen branch December 15, 2019 22:55
flokli added a commit to flokli/pynq that referenced this pull request Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants