Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: fix desktop icon #75682

Merged
merged 1 commit into from Dec 15, 2019
Merged

wire-desktop: fix desktop icon #75682

merged 1 commit into from Dec 15, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Dec 15, 2019

Update the Name attribute in the wire-desktop.desktop applications file.
This fixes the icons on plasma5 which, in certain places,
showed a generic X.org logo instead of the Wire logo.

Either Name or StartupWMClass needed to be set to Wire for intended behavior.
Updating Name was fewer LOC. :)

Motivation for this change

Plasma5 would show a generic X.org icon instead of the Wire icon because the Name/StartupWMClass weren't right.

Things done

This updates the Name in the share/applications/wire-desktop.desktop file to Wire instead of Wire Desktop.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@ofborg ofborg bot requested review from toonn and worldofpeace December 15, 2019 07:15
toonn
toonn approved these changes Dec 15, 2019
View reviewed changes
Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be accurate, the name of the application is reported as Wire on macOS too.

@Kiwi @worldofpeace
wire-desktop: fix desktop icon
4a73fbc 
Update the Name attribute in the wire-desktop.desktop applications file
and add StartupWMClass key. This fixes the icons on plasma5 and gnome3
which, in certain places, showed a generic X.org icon instead of the Wire
icon.
@worldofpeace
Copy link
Contributor

@Kiwi I actually had to add the StartupWMClass for gnome3. IIRC, this is what we have to do for the silly electron apps 😏

@worldofpeace worldofpeace merged commit ce549dd into NixOS:master Dec 15, 2019
@worldofpeace
Copy link
Contributor

I can imagine this is seriously annoying on some DE's, so I backported to 19.09 9436766.

@ofborg ofborg bot requested a review from toonn December 15, 2019 21:59
@Kiwi
Copy link
Member Author

Kiwi commented Dec 15, 2019

@Kiwi I actually had to add the StartupWMClass for gnome3. IIRC, this is what we have to do for the silly electron apps smirk

Oh. Well now we know. I wouldn't be able to check anyway because gnome3 has never worked when I've tried it so. :(

@Kiwi Kiwi deleted the wire-desktop-icon branch January 10, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@toonn toonn Awaiting requested review from toonn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kiwi @worldofpeace @toonn