treewide: https://cache.nixos.org/ -> https://cache.nixos.org #74271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
reviewed
Nov 26, 2019
| @@ -380,7 +380,7 @@ in | |||
| config = { | |||
|
|
|||
| nix.binaryCachePublicKeys = [ "cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=" ]; | |||
| nix.binaryCaches = [ "https://cache.nixos.org/" ]; | |||
There was a problem hiding this comment.
That's not a good idea, since there might be someone relying on that slash (cachix is).
There was a problem hiding this comment.
By relying, are you referring to https://github.com/cachix/cachix/blob/275f732676c06aa23ae6c93049c5e54cb12ce30c/cachix/src/Cachix/Client/InstallationMode.hs#L158, i.e. there will be two copies of the same binary cache listed in /etc/nix/nix.conf?
|
Yup.
…On Tue, Nov 26, 2019 at 5:04 PM Yegor Timoshenko ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nixos/modules/services/misc/nix-daemon.nix
<#74271 (comment)>:
> @@ -380,7 +380,7 @@ in
config = {
nix.binaryCachePublicKeys = [ "cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=" ];
- nix.binaryCaches = [ "https://cache.nixos.org/" ];
By relying, are you referring to
https://github.com/cachix/cachix/blob/275f732676c06aa23ae6c93049c5e54cb12ce30c/cachix/src/Cachix/Client/InstallationMode.hs#L158,
i.e. there will be two copies of the same binary cache listed in
/etc/nix/nix.conf?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#74271?email_source=notifications&email_token=AAA63AYITDVP52CUBWQES5TQVVCKHA5CNFSM4JRZYKR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNBBSSA#discussion_r350834397>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA63A27RJHMBF3XM6UO2ELQVVCKHANCNFSM4JRZYKRQ>
.
|
|
Closing, see #74271 (comment). |
|
@domenkozar Thanks for the prompt feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The latter seems to be marginally nicer.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @domenkozar