Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.containers*: port to python #74196

Merged
merged 4 commits into from Nov 25, 2019
Merged

nixosTests.containers*: port to python #74196

merged 4 commits into from Nov 25, 2019

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Nov 25, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @flokli @Lassulus

@tfc tfc mentioned this pull request Nov 25, 2019
Closed
@tfc
Copy link
Contributor Author

tfc commented Nov 25, 2019

@GrahamcOfBorg test containers-ephemeral containers-hosts containers-reloadable containers-tmpfs

flokli
flokli reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nitpick.

nixos/tests/containers-reloadable.nix Outdated Show resolved Hide resolved
@tfc tfc force-pushed the nixos-test-containers-python-port branch from aa998a2 to ab374b3 Compare November 25, 2019 21:20
@flokli flokli changed the title Nixos test containers python port nixosTests.containers*: port to python Nov 25, 2019
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

@GrahamcOfBorg test containers-ephemeral containers-hosts containers-reloadable containers-tmpfs

@flokli flokli merged commit 19ba87f into NixOS:master Nov 25, 2019
@tfc tfc deleted the nixos-test-containers-python-port branch November 25, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tfc @flokli