Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webtorrent source build #74056

Closed
wants to merge 4 commits into from
Closed

Webtorrent source build #74056

wants to merge 4 commits into from

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Nov 24, 2019

Motivation for this change

Build more packages from source and re-use nixos' built electron.

Also version updates.

Things done
  • Renamed webtorrent_desktop -> webtorrent_desktop_bin and removed hydra build
  • Re-Initialized webtorrent_desktop as a source build with auto-updater
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli

bendlas
bendlas commented Nov 26, 2019
View reviewed changes
Copy link
Contributor Author

@bendlas bendlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't build outside of my machine :-(

pkgs/applications/video/webtorrent_desktop/node-packages.nix Outdated
};
};
"load-json-file-1.1.0" = {
name = "load-jso
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. Let me check how to embed the fetch source here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renders wront :-/
this is the line https://github.com/NixOS/nixpkgs/pull/74056/files/c8c8627fa36fddd5a3c2a106b5f2f0d5b592f0fb#diff-620905878edda2a966e61192c9004855R3777

@flokli
Copy link
Contributor

flokli commented Nov 28, 2019

This fails evaluation.

On top of that, I'm not sure if building electron apps from source is worth the effort - they tend to be quite strict in what version of electron they assume…

@bendlas
Copy link
Contributor Author

bendlas commented Nov 28, 2019

webtorrent works fine in a range from electron 4-7, currently.

@bendlas
Copy link
Contributor Author

bendlas commented Nov 28, 2019

the failure is because I used node2nix wrong. fixing ...

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@flokli
Copy link
Contributor

flokli commented Jun 1, 2020

@bendlas it seems you never pushed the version fixing the evaluation.

Do you still want to pursue this?

@bendlas
Copy link
Contributor Author

bendlas commented Jul 10, 2020

Pushed v0.21 428b435

I'd still like to take another stab at this, though ...

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 10, 2020
@bendlas
Copy link
Contributor Author

bendlas commented Jul 10, 2020

Or not c255b0f

@bendlas
Copy link
Contributor Author

bendlas commented Jul 12, 2020

I got the source build fixed up and the program starts, but downloads don't work ... pushing the branch for reference, if somebody wants work on it, but closing for now. Pushed 9efcb76 instead.

@bendlas bendlas closed this Jul 12, 2020
@bendlas bendlas deleted the webtorrent-source-build branch October 22, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendlas @flokli