make-iso9660-image: produce stable GPT disk GUID #74174

raboof · 2019-11-25T17:36:32Z

By generating a version-5 GUID based on $out (which contains
the derivation hash) and preventing isohybrid from overwriting
the GPT table (which already is populated correctly by xorriso).

Tested by booting from UEFI USB disk

Fixes #74047

Things done

Notify maintainers

cc @

nixos/lib/make-iso9660-image.sh

raboof · 2019-11-25T22:13:08Z

I guess the main thing to consider/test here is whether dropping --uefi from the isohybrid invocation is safe. It seems safe from my tests, but looking at the image with cfdisk it changed quite a lot (it is now 1 big partition instead of 2 separate ones). I'd love input on this!

samueldr · 2019-11-26T03:10:44Z

From the Syslinux documentation (wiki)

Alternatively, the ISO 9660 production program "xorriso" can enhance its results by isohybrid, if an MBR template file from the local Syslinux installation is provided. The names of these files match the "isohdp[fp]x*.bin" pattern and are to be found in Syslinux under the "./[bios/]mbr" directory or installed as, for example, "/usr/lib/syslinux/isohdpfx.bin".
[...]
The resulting ISO image needs no further treatment by isohybrid tools.
— https://wiki.syslinux.org/wiki/index.php?title=Isohybrid

It looks like the isohybrid from Syslinux can be removed entirely, as long as xorriso is given the appropriate files to embed.

There is also a section about UEFI documenting the proper invocation for xorriso.

raboof · 2019-11-26T09:49:55Z

It looks like the isohybrid from Syslinux can be removed entirely

Good find - looks like the needed xorriso flags were already being passed in. My laptop can indeed still boot from the iso-written-to-USBdisk with isohybrid skipped entirely. Updated the PR.

raboof · 2019-11-26T09:52:00Z

/cc @lostdj @bobvanderlinden who have worked on these parts of the script before, way back in 2014/2015 though ;)

bobvanderlinden · 2019-11-26T10:41:29Z

nixos/lib/make-iso9660-image.sh

@@ -117,15 +118,6 @@ xorriso="xorriso

 $xorriso -output $out/iso/$isoName

-if test -n "$usbBootable"; then


I'm not sure whether we can remove isohybrid. It could very well be that the parameters passed to xorriso are already sufficient, but from what I remember there were quite a few systems we needed to support. Make sure to test this on a UEFI machine, a legacy bios machine and an OSX machine. Or is there some other way to verify the change doesn't affect these systems?

If we're indeed removing this, we might as well remove the usbBootable options from make-iso9660-image.nix. Might be better to do this in a separate PR.

(I've since tested this both on UEFI, non-UEFI and OSX machines. agreed to do further refactoring in a separate PR)

raboof · 2019-11-26T11:48:12Z

Also successfully tested on an old HP Compaq gw687aw machine from USB.

So left to test:

OSX
Booting from an actual CD instead of USB?

For your testing convenience, https://we.tl/t-ON1G9XIYPG

raboof · 2019-12-03T11:50:23Z

I have burnt the above ISO to a DVD-R and verified I could boot from it both on an old non-UEFI system and on a recent UEFI system.

raboof · 2019-12-03T20:19:02Z

And I've tested booting from the ISO on an OSX machine as well, now, too. Held the 'C' button to boot from the CD. This put me into a grub shell (probably we held the 'C' too long?), but after giving the normal command on the grub prompt it successfully booted the installation.

raboof · 2019-12-11T08:17:04Z

I have also tested that when applying this change together with #75484, nix-build ./nixos/release-combined.nix -A nixos.iso_minimal.x86_64-linux -I nixpkgs=~/nixpkgs-r13y --check now succeeds

domenkozar · 2019-12-11T08:43:27Z

@GrahamcOfBorg test installer

raboof · 2020-01-05T09:59:42Z

Since #75484 has now been merged I rebased & squashed this, and verified nix-build --check is still succeeding.

I think this should be good to go now?

raboof · 2020-01-05T09:59:59Z

@GrahamcOfBorg test installer

nixos-discourse · 2020-01-08T12:13:13Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/105

nixos-discourse · 2020-05-15T15:17:51Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/161

raboof · 2020-07-07T09:41:16Z

/marvin opt-in
/status awaiting_changes

marvin-mk2 · 2020-07-07T09:41:17Z

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

nixos-discourse · 2020-07-15T07:48:15Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-are-your-goals-for-20-09/8035/7

nixos/lib/make-iso9660-image.sh

By generating a version-5 GUID based on $out (which contains the derivation hash) and preventing isohybrid from overwriting the GPT table (which already is populated correctly by xorriso). Tested by: * booting from USB disk on a UEFI system * booting from USB disk on a non-UEFI system * booting from CD on a UEFI system * booting from CD on a non-UEFI system * booting from CD on an OSX system Also tested that "nix-build ./nixos/release-combined.nix -A nixos.iso_minimal.x86_64-linux -I nixpkgs=~/nixpkgs-r13y --check" now succeeds. Fixes NixOS#74047

timokau

Thanks!

ofborg bot added 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 25, 2019

jtojnar reviewed Nov 25, 2019

View reviewed changes

nixos/lib/make-iso9660-image.sh Outdated Show resolved Hide resolved

flokli requested a review from samueldr November 26, 2019 00:09

bobvanderlinden reviewed Nov 26, 2019

View reviewed changes

raboof force-pushed the fix-74047-stable-gpt-disk-guid branch from 8072fc5 to 3827792 Compare December 11, 2019 07:52

raboof mentioned this pull request Dec 11, 2019

installer/cd-dvd/iso-image: avoid leaking build timestamps #75484

Merged

raboof force-pushed the fix-74047-stable-gpt-disk-guid branch from 3827792 to 59dff7d Compare January 5, 2020 09:57

raboof mentioned this pull request Jan 31, 2020

Collect links to incoming fixes grahamc/r13y.com#15

Closed

raboof requested review from bobvanderlinden and jtojnar April 6, 2020 13:40

marvin-mk2 bot added marvin awaiting_changes labels Jul 7, 2020

raboof force-pushed the fix-74047-stable-gpt-disk-guid branch from 59dff7d to 1bdc11b Compare July 7, 2020 15:19

marvin-mk2 bot added awaiting_reviewer needs_reviewer and removed awaiting_changes awaiting_reviewer labels Jul 7, 2020

marvin-mk2 bot requested a review from ryantm July 11, 2020 08:34

marvin-mk2 bot added awaiting_reviewer needs_reviewer and removed needs_reviewer awaiting_reviewer labels Jul 11, 2020

marvin-mk2 bot requested a review from fgaz July 14, 2020 19:40

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Jul 14, 2020

marvin-mk2 bot added needs_reviewer and removed awaiting_reviewer labels Jul 18, 2020

marvin-mk2 bot requested a review from timokau July 18, 2020 20:53

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Jul 18, 2020

timokau requested changes Jul 19, 2020

View reviewed changes

nixos/lib/make-iso9660-image.sh Show resolved Hide resolved

marvin-mk2 bot added awaiting_changes awaiting_reviewer and removed awaiting_reviewer awaiting_changes labels Jul 19, 2020

raboof force-pushed the fix-74047-stable-gpt-disk-guid branch from 1bdc11b to be006ea Compare July 20, 2020 09:17

raboof requested a review from timokau July 20, 2020 09:42

timokau approved these changes Jul 20, 2020

View reviewed changes

timokau merged commit 830a8d6 into NixOS:master Jul 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make-iso9660-image: produce stable GPT disk GUID #74174

make-iso9660-image: produce stable GPT disk GUID #74174

raboof commented Nov 25, 2019

raboof commented Nov 25, 2019 •

edited

samueldr commented Nov 26, 2019

raboof commented Nov 26, 2019

raboof commented Nov 26, 2019

bobvanderlinden Nov 26, 2019 •

edited

raboof Dec 30, 2019

raboof commented Nov 26, 2019 •

edited

raboof commented Dec 3, 2019

raboof commented Dec 3, 2019

raboof commented Dec 11, 2019 •

edited

domenkozar commented Dec 11, 2019

raboof commented Jan 5, 2020

raboof commented Jan 5, 2020

nixos-discourse commented Jan 8, 2020

nixos-discourse commented May 15, 2020

raboof commented Jul 7, 2020

marvin-mk2 bot commented Jul 7, 2020

nixos-discourse commented Jul 15, 2020

timokau left a comment

		@@ -117,15 +118,6 @@ xorriso="xorriso

		$xorriso -output $out/iso/$isoName

		if test -n "$usbBootable"; then

make-iso9660-image: produce stable GPT disk GUID #74174

make-iso9660-image: produce stable GPT disk GUID #74174

Conversation

raboof commented Nov 25, 2019

Things done

Notify maintainers

raboof commented Nov 25, 2019 • edited

samueldr commented Nov 26, 2019

raboof commented Nov 26, 2019

raboof commented Nov 26, 2019

bobvanderlinden Nov 26, 2019 • edited

Choose a reason for hiding this comment

raboof Dec 30, 2019

Choose a reason for hiding this comment

raboof commented Nov 26, 2019 • edited

raboof commented Dec 3, 2019

raboof commented Dec 3, 2019

raboof commented Dec 11, 2019 • edited

domenkozar commented Dec 11, 2019

raboof commented Jan 5, 2020

raboof commented Jan 5, 2020

nixos-discourse commented Jan 8, 2020

nixos-discourse commented May 15, 2020

raboof commented Jul 7, 2020

marvin-mk2 bot commented Jul 7, 2020

nixos-discourse commented Jul 15, 2020

timokau left a comment

Choose a reason for hiding this comment

raboof commented Nov 25, 2019 •

edited

bobvanderlinden Nov 26, 2019 •

edited

raboof commented Nov 26, 2019 •

edited

raboof commented Dec 11, 2019 •

edited