New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.owl: init at 0.7.1 #74274
Conversation
0aacfcc
to
e66e5f3
Compare
@GrahamcOfBorg build ocamlPackages.owl |
Maybe you could tweak the
|
b26b164
to
07b3fea
Compare
@vbgl -- flags adjusted on Aarch64. |
Owl itself has the same issue with SSE-related flags, so it might make more sense to set |
That’s up to you, as maintainer of these packages: do you want to figure out the right installation parameters for these architectures that you don’t use, or just claim that the package is only available for the architecture that you use. Minor notes:
|
Since I have no way to test on these architectures, I've just set platforms to x64 for now, which together with the Eigen version bump simplifies the derivation considerably. |
You’ve made a good choice. Final nitpick: eigen won’t build with OCaml < 4.04 Can you please add a “minimumOCamlVersion” to that derivation? Thanks. |
@vbgl - done! |
Thanks! |
Motivation for this change
Add a package and its dependencies (eigen, owl-base).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @