Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.owl: init at 0.7.1 #74274

Merged
merged 2 commits into from Nov 29, 2019
Merged

ocamlPackages.owl: init at 0.7.1 #74274

merged 2 commits into from Nov 29, 2019

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Nov 26, 2019

Motivation for this change

Add a package and its dependencies (eigen, owl-base).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/development/ocaml-modules/owl/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/owl-base/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/owl-base/default.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/owl-base/default.nix Outdated Show resolved Hide resolved
@vbgl
Copy link
Contributor

vbgl commented Nov 28, 2019

@GrahamcOfBorg build ocamlPackages.owl

@vbgl
Copy link
Contributor

vbgl commented Nov 28, 2019

Maybe you could tweak the EIGEN_FLAGS environment variable on Aarch64 (see: https://github.com/owlbarn/eigen/blob/068a74666322f575e32795ee9290b92a30e4a123/eigen/dune#L4-L6). Currently build fails with:

gcc: error: unrecognized command line option '-mfpmath=sse'

@bcdarwin
Copy link
Member Author

@vbgl -- flags adjusted on Aarch64.

@bcdarwin
Copy link
Member Author

Owl itself has the same issue with SSE-related flags, so it might make more sense to set platforms to x86_64 rather than make all these changes manually.

@vbgl
Copy link
Contributor

vbgl commented Nov 29, 2019

That’s up to you, as maintainer of these packages: do you want to figure out the right installation parameters for these architectures that you don’t use, or just claim that the package is only available for the architecture that you use.

Minor notes:

  • eigen-0.1.5 is out
  • You don’t have to “substituteInPlace” to change the compilation flags: simply setting the “EIGEN_FLAGS” and “OPTFLAGS0” environment variables should be enough.

@bcdarwin
Copy link
Member Author

Since I have no way to test on these architectures, I've just set platforms to x64 for now, which together with the Eigen version bump simplifies the derivation considerably.

@vbgl
Copy link
Contributor

vbgl commented Nov 29, 2019

You’ve made a good choice.

Final nitpick: eigen won’t build with OCaml < 4.04 Can you please add a “minimumOCamlVersion” to that derivation? Thanks.

@bcdarwin
Copy link
Member Author

@vbgl - done!

@vbgl vbgl merged commit d016a50 into NixOS:master Nov 29, 2019
@vbgl
Copy link
Contributor

vbgl commented Nov 29, 2019

Thanks!

@bcdarwin bcdarwin deleted the owl branch December 6, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants