Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyglet + alienarena + ati_drivers_x11: fix libGL and libGLU paths #74277

Merged
merged 3 commits into from Nov 26, 2019
Merged

pythonPackages.pyglet + alienarena + ati_drivers_x11: fix libGL and libGLU paths #74277

merged 3 commits into from Nov 26, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Nov 26, 2019

Motivation for this change

Fixup some paths that got messed up during #73261 rewrite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Nov 26, 2019

I'm not sure if staging is the correct target branch, as #73261 is already in staging-next.

Can/should I change the target branch?

@FRidh
Copy link
Member

FRidh commented Nov 26, 2019

in this case its a fixup for staging-next

@B4dM4n B4dM4n changed the base branch from staging to staging-next November 26, 2019 16:44
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 26, 2019
@FRidh FRidh merged commit a03b7eb into NixOS:staging-next Nov 26, 2019
@B4dM4n B4dM4n deleted the libglu-combined-fixup branch November 26, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @FRidh