Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noise-repellent: init at unstable-29-12-2018 #74204

Merged
merged 1 commit into from Nov 26, 2019
Merged

noise-repellent: init at unstable-29-12-2018 #74204

merged 1 commit into from Nov 26, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Nov 25, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Nov 26, 2019
View reviewed changes
pkgs/applications/audio/noise-repellent/default.nix Outdated

stdenv.mkDerivation rec {
pname = "noise-repellent";
version = "unstable-29-12-2018";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the date format is YYYY-MM-DD https://nixos.org/nixpkgs/manual/#sec-package-naming

Suggested change
version = "unstable-29-12-2018";
version = "unstable-29-12-2018";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Done.

jonringer
jonringer approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
no idea how to test

[3 built, 2 copied (1.3 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74204
1 package were built:
noise-repellent

@jonringer
Copy link
Contributor

@GrahamcOfBorg build noise-repellent

@jonringer
Copy link
Contributor

looks like arch doesn't like some of the compiler flags (architecture extensions), if arch is not a supported architecture, then I would change meta.platforms to reflect just the x86_64 variants

/nix/store/nalgbdpjmhizap3sp1q3lqinisifldl9-gcc-wrapper-8.3.0/bin/cc -Inrepel@sha -I. -I.. -I/nix/store/mwjc8kdg97nbl07bwsr96arkqmiz2v1w-fftw-single-3.3.8-dev/include -I/nix/store/6n1ib7m8axh6k75n6v9nkhbxp7s89ym6-lv2-1.16.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=c99 -fPIC -msse -msse2 -mfpmath=sse -ffast-math -fomit-frame-pointer -fno-finite-math-only -MD -MQ 'nrepel@sha/src_nrepel.c.o' -MF 'nrepel@sha/src_nrepel.c.o.d' -o 'nrepel@sha/src_nrepel.c.o' -c ../src/nrepel.c
gcc: error: unrecognized command line option '-msse'; did you mean '-fdse'?
gcc: error: unrecognized command line option '-msse2'
gcc: error: unrecognized command line option '-mfpmath=sse'
ninja: build stopped: subcommand failed.
builder for '/nix/store/7zy3w7g3mpk39zyr1ag7w8iwg364clg2-noise-repellent-unstable-2018-12-29.drv' failed with exit code 1
error: build of '/nix/store/7zy3w7g3mpk39zyr1ag7w8iwg364clg2-noise-repellent-unstable-2018-12-29.drv' failed

@magnetophon
Copy link
Member Author

OK, platforms are updated.

@jonringer jonringer merged commit fd2f245 into NixOS:master Nov 26, 2019
@magnetophon magnetophon deleted the noise-repellent branch November 26, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @jonringer