Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests: fail on failing subtests #74089

Merged
merged 1 commit into from Nov 25, 2019
Merged

nixos/tests: fail on failing subtests #74089

merged 1 commit into from Nov 25, 2019

Conversation

globin
Copy link
Member

@globin globin commented Nov 25, 2019

Motivation for this change

This was the behaviour in the perl test driver too and a regression.

Also cleaned up unused imports

cc @flokli

@globin
nixos/tests: fail on failing subtests
ba03a1b 
This was the behaviour in the perl test driver too and a regression.

Also cleaned up unused imports
@globin globin requested a review from flokli November 25, 2019 00:11
flokli
flokli approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Thanks :-)

@flokli flokli merged commit 085ead7 into NixOS:master Nov 25, 2019
@tfc
Copy link
Contributor

tfc commented Nov 25, 2019

@tfc It's here #74089.

Oh, my bad then! Thank you. Please put me on the reviewer's list in the future, too, as i have a lot of stakes in the python test driver since i wrote it and am interested to be on track what's changed. That would be nice.

@worldofpeace
Copy link
Contributor

@tfc It's here #74089.

Oh, my bad then! Thank you. Please put me on the reviewer's list in the future, too, as i have a lot of stakes in the python test driver since i wrote it and am interested to be on track what's changed. That would be nice.

Absolutely 👍 You might even consider adding yourself to CODEOWNERS for the files.

@flokli flokli mentioned this pull request Feb 6, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@globin @tfc @worldofpeace @flokli