Adding .csv trace file import functionality #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the use case? |
|
Here is a good example: https://www.youtube.com/watch?v=i6tDWJsNsok |
|
Hmm, interesting. How do you deal with dragging producing a large number of points, causing a slowdown? Do you use "Step Dimension"? Otherwise, I think it is reasonable to support this but it would probably be better with a menu option. |
|
Yeah I am using step dimension over here but the code ignores duplicate
coordinates which might help already, we could perhaps add a minimum
distance of points for the import.
…On Sun, 24 Nov 2019 at 21:44, whitequark ***@***.***> wrote:
Hmm, interesting. How do you deal with dragging producing a large number
of points, causing a slowdown? Do you use "Step Dimension"?
Otherwise, I think it is reasonable to support this but it would probably
be better with a menu option.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#507?email_source=notifications&email_token=AAGV4VKUV63Y5NWKNKN474LQVLRS3A5CNFSM4JRA2RXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFAUNZI#issuecomment-557926117>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGV4VPBLZ5ZPJYVOUNLELLQVLRS3ANCNFSM4JRA2RXA>
.
|
phkahler
force-pushed
the
master
branch
2 times, most recently
from
dfb96de
to
3f09eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know how useful this is, but if it is, let me know and I will fix the translations.
Also, we might be able to add a menu option that turns the trace directly into a line in stead of having to go through the save trace -> import flow.
Also, I am not a professional C++ programmer so let me know if I am doing anything wrong.
Cheers