Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibc: add patch for CVE-2019-19126 #74075

Merged
merged 1 commit into from Dec 10, 2019
Merged

glibc: add patch for CVE-2019-19126 #74075

merged 1 commit into from Dec 10, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 24, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-19126

Including patch in-repo as it needs modification to remove the changes to NEWS but fetchpatch doesn't work here.

Have fun with the rebuilds!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
glibc: add patch for CVE-2019-19126
b9deb1e 
including patch in-repo as it needs modification to remove the changes to
NEWS but fetchpatch doesn't work here
@ofborg ofborg bot requested a review from edolstra November 24, 2019 20:24
@FRidh FRidh added this to Needs review in Staging Nov 30, 2019
@FRidh FRidh merged commit 9234d1d into NixOS:staging Dec 10, 2019
Staging automation moved this from Needs review to Done Dec 10, 2019
@risicle risicle mentioned this pull request Dec 11, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @veprbl @FRidh