Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irony-server: Fix failing build with 1.4.0 cmake files #74223

Merged
merged 1 commit into from Nov 26, 2019
Merged

irony-server: Fix failing build with 1.4.0 cmake files #74223

merged 1 commit into from Nov 26, 2019

Conversation

bhpdt
Copy link

@bhpdt bhpdt commented Nov 26, 2019 •
edited

The irony-server binary package tracks the irony-server elisp package, which was
upgraded to 1.4.0. This is now failing on Hydra because upstream has refactored
the CMake build, and now require CMake files from LLVM.

This should fix the failing build on Hydra:
https://hydra.nixos.org/build/107005523

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @deepfire

irony-server: Fix build with 1.4.0 cmake files
33e0ffe 
The irony-server binary package tracks the irony-server elisp package, which was
upgraded to 1.4.0. This is now failing on Hydra because upstream has refactored
the CMake build, and now require CMake files from LLVM.
@ofborg ofborg bot requested a review from deepfire November 26, 2019 01:01
jonringer
jonringer approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does indeed fix build
diff LGTM
executable shows usage

[2 built, 1 copied (0.5 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74223
1 package were built:
irony-server

@jonringer
Copy link
Contributor

@GrahamcOfBorg build irony-server

@matthewbauer matthewbauer merged commit a6ea6e2 into NixOS:master Nov 26, 2019
@ahiaao ahiaao mentioned this pull request Nov 30, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@deepfire deepfire Awaiting requested review from deepfire

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhpdt @jonringer @matthewbauer