Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-subtrac: init at 0.01 #74224

Merged
merged 1 commit into from
Nov 26, 2019
Merged

gitAndTools.git-subtrac: init at 0.01 #74224

merged 1 commit into from
Nov 26, 2019
+24 −0

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 26, 2019

Motivation for this change

Add https://github.com/apenwarr/git-subtrac

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@marsam
gitAndTools.git-subtrac: init at 0.01

Unverified

No user is associated with the committer email.
Learn about vigilant mode
ebf046b
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 26, 2019
@ofborg ofborg bot requested a review from kalbasit November 26, 2019 01:00
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 26, 2019
jonringer
jonringer approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74224
1 package were built:
gitAndTools.git-subtrac

@jonringer
Copy link
Contributor

@GrahamcOfBorg build gitAndTools.git-subtrac

@jonringer jonringer merged commit ebde766 into NixOS:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@kalbasit kalbasit

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jonringer