Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.4.3 -> 12.5.0 #74278

Merged
merged 5 commits into from Nov 27, 2019
Merged

gitlab: 12.4.3 -> 12.5.0 #74278

merged 5 commits into from Nov 27, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Nov 26, 2019 •
edited

Things done

  • Tested locally in a VM

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

Notify maintainers

cc @flokli @petabyteboy @globin @fpletz @krav

@talyz
Copy link
Contributor Author

talyz commented Nov 26, 2019

@GrahamcOfBorg test gitlab

@ofborg ofborg bot requested review from krav, ehmry, globin and fpletz November 26, 2019 16:44
@mweinelt
Copy link
Member

Meanwhile 12.5.1 is out. It's a security release.

https://about.gitlab.com/blog/2019/11/27/security-release-gitlab-12-5-1-released/?utm_medium=social&utm_source=twitter&utm_campaign=securityrelease

@flokli
Copy link
Contributor

flokli commented Nov 27, 2019

pushed an update to 12.5.2, another security release from 2 hours ago.

@flokli
Copy link
Contributor

flokli commented Nov 27, 2019

@GrahamcOfBorg test gitlab

@flokli flokli merged commit f1c7891 into NixOS:master Nov 27, 2019
@flokli
Copy link
Contributor

flokli commented Nov 27, 2019

backported to 19.09 in e5820bd, 6aaa427, 839b01b, 73fb59d.

talyz
talyz commented Nov 28, 2019
View reviewed changes
Copy link
Contributor Author

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't think this is right... moretea.yarn2nix was recently renamed to yarn2nix; maybe your nix-shell was using an old version of nixpkgs?

@flokli
Copy link
Contributor

flokli commented Nov 28, 2019

@talyz yarn2nix-moretea.yarn2nix should still work on master, but you're right - we should just call it yarn2nix if possible. Reverted in b5cbd81.

@veprbl veprbl mentioned this pull request Dec 4, 2019
Closed
@talyz talyz deleted the gitlab-12.5.0 branch June 16, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krav krav Awaiting requested review from krav

@ehmry ehmry Awaiting requested review from ehmry

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @mweinelt @flokli