New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtualbox: 6.0.12 -> 6.0.14 #74260
virtualbox: 6.0.12 -> 6.0.14 #74260
Conversation
related / duplicate: #75463 |
./kernel-5.3-fix.patch | ||
# Kernel 5.4 fix, should be fixed with next upstream release | ||
# https://www.virtualbox.org/ticket/18945 | ||
./kernel-5.4-fix.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fetchpatch
these instead of adding them to the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could literally copy the fetchpatch
statements from #75463.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never got the build completely through with the patches in that PR so unfortunately it wouldn't be sufficient to copy that PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But perhaps it would work with copying them to the guest-additions package as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could literally copy the
fetchpatch
statements from #75463.
I could not find the patch URLs before on the virtualbox site. Using the URLs from #75463 is working great.
I never got the build completely through with the patches in that PR so unfortunately it wouldn't be sufficient to copy that PR.
There is a third cahngeset which was missing in your PR. Adding https://www.virtualbox.org/changeset/81649/vbox builds fine.
But perhaps it would work with copying them to the guest-additions package as well?
It's not so easy to use fetchpatch for the guest additions. Only some of the changes are needed and they are in multiple sub folders. I'm looking for a solution to reuse the upstream patches.
use fetchpatch in guest additions
I updated the PR to use The guest additions patches are a bit messy, as they need to reused with different prefixes and includes. |
@GrahamcOfBorg test virtualbox |
I built 19.09 with these commits (unfortunately the fixup patches were not squashed) and everything seems to work well on Linux 5.4. Unless complaints arise I'll therefore cherry-pick the changes to the release-19.09 branch tomorrow (Dec 14). |
This reverts commit 63c756d. Fixes issue NixOS#74916
Update Virtualbox to its latest version. This allows compilation against kernel >= 5.4 to succeed without further patches (see NixOS#74260, build would fail for linux-5.5.5 to 5.5.9).
Update Virtualbox to its latest version. This allows compilation against kernel >= 5.4 to succeed without further patches (see #74260, build would fail for linux-5.5.5 to 5.5.9).
Update Virtualbox to its latest version. This allows compilation against kernel >= 5.4 to succeed without further patches (see NixOS#74260, build would fail for linux-5.5.5 to 5.5.9). (cherry picked from commit 2b99b29)
Update Virtualbox to its latest version. This allows compilation against kernel >= 5.4 to succeed without further patches (see NixOS#74260, build would fail for linux-5.5.5 to 5.5.9). (cherry picked from commit 3132c23)
Update Virtualbox to its latest version. This allows compilation against kernel >= 5.4 to succeed without further patches (see NixOS#74260, build would fail for linux-5.5.5 to 5.5.9). (cherry picked from commit 3132c23)
Motivation for this change
The
virtualbox
build is failing withlinuxPackages_5_4
. Instead of fixing the build for the old release I decided to update the package and fix the compile errors afterwards.Things done
VBoxManage startvm --type=headless
withsandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @flokli @svanderburg @cdepillabout