Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.riak: port to python #74124

Merged
merged 2 commits into from Jan 31, 2020
Merged

nixosTests.riak: port to python #74124

merged 2 commits into from Jan 31, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 25, 2019 •
edited

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg test riak

@Mic92
Copy link
Member

Mic92 commented Nov 25, 2019

riak is not yet in all-tests.nix. However it could be added. Than also @GrahamcOfBorg test riak would work.

@Mic92
Copy link
Member

Mic92 commented Nov 25, 2019 •
edited

Might be also worth to bump riak: https://github.com/basho/riak/releases/tag/riak-2.9.0p5
The current version is marked as insecure. So the test won't build.

@tfc tfc mentioned this pull request Nov 25, 2019
Closed
@worldofpeace worldofpeace added this to the 20.03 milestone Jan 31, 2020
@worldofpeace worldofpeace self-assigned this Jan 31, 2020
@worldofpeace
Copy link
Contributor

this makes me question things #33876 (comment). good to merge though, no point of adding to all-tests.nix because it can't even eval it

@worldofpeace worldofpeace merged commit 758b1b9 into NixOS:master Jan 31, 2020
@worldofpeace worldofpeace removed their assignment Jan 31, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#74124 from filalex77/nixosTests.riak-python
4803900 
nixosTests.riak: port to python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Br1ght0ne @Mic92 @worldofpeace @tfc