Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.m2crypto: conditional typing dep #74190

Merged
merged 1 commit into from Nov 25, 2019
Merged

pythonPackages.m2crypto: conditional typing dep #74190

merged 1 commit into from Nov 25, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

Since python 3.5 typing is included in the stdlib and as such
this library should not be included and propagated for >=3.5.

This is loosely related to #73927 - specifically to upgrading
tribler to a python 3 supporting version (separate pending PR).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andrew-d

@d-goldin
pythonPackages.m2crypto: conditional typing dep
22ffab0 
Since python 3.5 typing is included in the stdlib and as such
this library should not be included and propagated for >=3.5.
@ofborg ofborg bot requested a review from andrew-d November 25, 2019 20:27
@flokli flokli merged commit 5cae875 into NixOS:master Nov 25, 2019
@d-goldin d-goldin deleted the m2crypto_typing_dep branch November 25, 2019 21:02
andrew-d
andrew-d reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc LGTM 👍

@jonringer
Copy link
Contributor

actually, you can have clashes with having typing installed >=3.6, so it's good to remove this, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-goldin @jonringer @andrew-d @flokli