Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphinEmuMaster: 5.0-11109 -> 5.0-11288 #74236

Closed
wants to merge 1 commit into from
Closed

dolphinEmuMaster: 5.0-11109 -> 5.0-11288 #74236

wants to merge 1 commit into from

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 26, 2019 •
edited

Motivation for this change

Bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Moredread
Copy link
Contributor Author

cc @MP2E @ashkitten

@Moredread
Copy link
Contributor Author

I guess when reviewing it would make sense to update to the latest master. Feel free to push your update to this PR.

@ofborg ofborg bot requested review from ashkitten and MP2E November 26, 2019 02:17
@ashkitten
Copy link
Contributor

i'm of the mind that we should try to stay on the monthly updates (after a progress report) since those are more thoroughly tested for the progress report and are less likely to break. it hasn't even been 3 weeks since the last update to this package, so unless there's some change you think is important to include then i think we should wait for the next progress report.

@Moredread
Copy link
Contributor Author

@ashkitten sounds like a good policy, closing the PR

@Moredread Moredread closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashkitten ashkitten Awaiting requested review from ashkitten

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Moredread @ashkitten