Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runelite: 1.6.0 -> 2.0.0 #74136

Merged
merged 1 commit into from Jan 6, 2020
Merged

runelite: 1.6.0 -> 2.0.0 #74136

merged 1 commit into from Jan 6, 2020

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 25, 2019

Motivation for this change

2.0.2 (latest) doesn't provide a RuneLite.jar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Kmeakin


This change is Reviewable

@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build runelite

@Br1ght0ne
Copy link
Member Author

Thanks @marsam!

@Br1ght0ne Br1ght0ne requested a review from marsam January 6, 2020 13:22
Co-authored-by: Mario Rodas <marsam@users.noreply.github.com>
@marsam marsam merged commit b103b3f into NixOS:master Jan 6, 2020
@marsam
Copy link
Contributor

marsam commented Jan 6, 2020

Thank you @filalex77!

@Br1ght0ne Br1ght0ne deleted the runelite-2.0.0 branch January 6, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants