Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana: 6.4.4 -> 6.4.5 #74140

Merged
merged 1 commit into from Nov 25, 2019
Merged

grafana: 6.4.4 -> 6.4.5 #74140

merged 1 commit into from Nov 25, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

New patch release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64-linux & aarch64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test grafana

@WilliButz WilliButz added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 25, 2019
jonringer
jonringer approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commit LGTM
executables show usage

[4 built, 4 copied (379.7 MiB), 97.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74140
1 package were built:
grafana

@jonringer
Copy link
Contributor

tests passed

@jonringer jonringer merged commit 12c1f4b into NixOS:master Nov 25, 2019
@WilliButz WilliButz deleted the update-grafana branch November 25, 2019 17:33
@WilliButz
Copy link
Member Author

backported in e3eaf19

@WilliButz WilliButz removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 26, 2019
@jonringer jonringer added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @jonringer