Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onefetch: init at 2.1.0 #74191

Merged
merged 1 commit into from Nov 27, 2019
Merged

onefetch: init at 2.1.0 #74191

merged 1 commit into from Nov 27, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 25, 2019 •
edited

Motivation for this change

Close #72254

@Kloenk - feel free to add yourself as a maintainer, if you'd like.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @jonringer

This change is Reviewable

@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build onefetch

@Br1ght0ne Br1ght0ne mentioned this pull request Nov 25, 2019
Closed
jonringer
jonringer approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74191
1 package were built:
onefetch

@jonringer
Copy link
Contributor

@GrahamcOfBorg build onefetch

@Br1ght0ne
Copy link
Member Author

Br1ght0ne commented Nov 26, 2019 •
edited

@jonringer Build on darwin should be fixed now, please re-run the darwin build.

@GrahamcOfBorg build onefetch

@Kloenk Kloenk mentioned this pull request Nov 26, 2019
Closed
10 tasks
@jonringer
Copy link
Contributor

@GrahamcOfBorg build onefetch

@Br1ght0ne @Kloenk
onefetch: init at 2.1.0
d06859a 
Co-authored-by: Kloenk <Kloenk@users.noreply.github.com>
@Br1ght0ne
Copy link
Member Author

@jonringer I think I added all the needed frameworks and libraries for Darwin now. Could you please run the build again? Sorry to ping you so much; the PR adding me to trusted users for ofBorg is not merged yet.

@Br1ght0ne Br1ght0ne mentioned this pull request Nov 26, 2019
Merged
@jonringer
Copy link
Contributor

@GrahamcOfBorg build onefetch

@Br1ght0ne
Copy link
Member Author

@jonringer I think it's fine now - the PR can be merged. Thanks a lot for your help!

Br1ght0ne added a commit to Br1ght0ne/onefetch that referenced this pull request Nov 27, 2019
@Br1ght0ne
Delete default.nix
4c42e9f 
After NixOS/nixpkgs#74191 gets merged, this fine is no longer necessary.

cc @Kloenk
@Br1ght0ne Br1ght0ne mentioned this pull request Nov 27, 2019
Closed
@jonringer
Copy link
Contributor

previous review still stand, LGTM

@jonringer jonringer merged commit fb00dac into NixOS:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Br1ght0ne @jonringer