nixosTests.nginx*: port to python #74072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
requested changes
Nov 24, 2019
globin
force-pushed
the
tests-python-nginx
branch
2 times, most recently
from
5f7c28d
to
625dc56
Compare
tfc
reviewed
Nov 25, 2019
tfc
requested changes
Dec 1, 2019
|
ping @globin |
Merged
10 tasks
|
@GrahamcOfBorg test nginx nginx-sso |
Co-Authored-By: Florian Klink <flokli@flokli.de>
When using format-strings, curly brackets need to be escaped using `{{`
to avoid errors from python.
And apparently, Perl's `==` is used to compare substrings[1] which is why
the translation to `assert http_code == "304"` failed as the string
contains several headers from curl.
[1] Just check `perl <(echo 'die "alarm" if "foo\n304" == 304')`
Ma27
force-pushed
the
tests-python-nginx
branch
from
ea37727
to
c5c7ccf
Compare
|
Rebased onto latest master, fixed the @GrahamcOfBorg test nginx nginx-sso |
Ma27
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)