Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediately edit dimension after adding it #512

Closed

Conversation

vespakoen
Copy link
Contributor

@vespakoen vespakoen commented Nov 26, 2019

Having to double click the dimensions after adding them can be quite annoying when adding a lot of dimensions, I think the default should be to directly show the input field when adding a dimension.

This PR changes that.

Hope it's helpful.

@neuks
Copy link

neuks commented Nov 26, 2019

This works good, and more user friendly, I have added it to my local source pool, thanks.

@whitequark
Copy link
Contributor

I don't think changing the defaults to benefit one person's choice of workflow at the expense of everyone else adjusting their workflow in response is appropriate.

@whitequark whitequark closed this Nov 26, 2019
@vespakoen
Copy link
Contributor Author

Would love to hear the alternate workflow that I am unaware of then, I have seen some references of a grid in the code, so I guess that has to do with it?

My girlfriend gave up on my little solvespace tutorial once she was adding in dimensions.

Directly entering the value also is the default of most other CAD programs as far as I know.

I think this should be reconsidered or added as an option to the config.

@whitequark
Copy link
Contributor

Would love to hear the alternate workflow that I am unaware of then

Double-clicking the dimension after adding it.

A configuration option for this seems fine.

@vespakoen
Copy link
Contributor Author

Ok I will add a configuration option for it later.

@whitequark
Copy link
Contributor

whitequark commented Nov 26, 2019

I've reopened the PR and I'll merge it once you add the configuration option.

@whitequark whitequark reopened this Nov 26, 2019
@vespakoen
Copy link
Contributor Author

vespakoen commented Nov 26, 2019

See #515

@vespakoen vespakoen closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants