Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.03] mosquitto: 1.5.8 -> 1.5.9, addressing CVE-2019-11779 #74210

Merged
merged 1 commit into from Nov 26, 2019
Merged

[r19.03] mosquitto: 1.5.8 -> 1.5.9, addressing CVE-2019-11779 #74210

merged 1 commit into from Nov 26, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 25, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-11779

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2019

Ooooooh that's a cute one!! 😸

a SUBSCRIBE packet containing a topic that consists of approximately 65400 or more '/' characters, i.e. the topic hierarchy separator, then a stack overflow will occur

@ofborg ofborg bot requested a review from peterhoeg November 25, 2019 23:26
Lassulus
Lassulus approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to start correctly

@Lassulus Lassulus merged commit 27f4879 into NixOS:release-19.03 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @c0bw3b @Lassulus