Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.papermill: init at 1.2.1 #74208

Merged
merged 3 commits into from Nov 26, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

@anirrudh wanted this package :) Would be nice to have more jupyterlab python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@costrouc
Copy link
Member Author

Result of nix-review pr 74208 1

9 package were built:
  • python27Packages.ansiwrap
  • python27Packages.papermill
  • python27Packages.textwrap3
  • python37Packages.ansiwrap
  • python37Packages.papermill
  • python37Packages.textwrap3
  • python38Packages.ansiwrap
  • python38Packages.papermill
  • python38Packages.textwrap3

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansiwrap and textwrap both haven't seen an update since January :(, not sure how i feel about them.

@costrouc
Copy link
Member Author

@jonringer while it is true that both have not been updated since January they both have their test suites fully enabled and have no external dependencies (ansiwrap depends on textwrap3, textwrap3 has no dependencies). I think these packages should be easy to maintain for this reason.

@jonringer
Copy link
Contributor

That's fair. They do look like they had some release polish

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/74208
9 package were built:
python27Packages.ansiwrap python27Packages.papermill python27Packages.textwrap3 python37Packages.ansiwrap python37Packages.papermill python37Packages.textwrap3 python38Packages.ansiwrap python38Packages.papermill python38Packages.textwrap3

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.ansiwrap python27Packages.papermill python27Packages.textwrap3 python37Packages.ansiwrap python37Packages.papermill python37Packages.textwrap3 python38Packages.ansiwrap python38Packages.papermill python38Packages.textwrap3

@jonringer
Copy link
Contributor

darwin failure related to sqlalchemy

@jonringer jonringer merged commit 2f288db into NixOS:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants