Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regroup all themes under data/themes #74060

Merged
merged 5 commits into from Nov 25, 2019
Merged

Regroup all themes under data/themes #74060

merged 5 commits into from Nov 25, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 24, 2019 •
edited

Motivation for this change

Top-level misc folder is really not a good place to put things away so :
+ move remaining mislocated themes under data/themes
+ updated 3 KDE themes
+ locate GTK theming libraries ("engines") under development/libraries

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @romildo @gnidorah

@c0bw3b
kde2-decoration: 2017-03-15 -> 1.0
910d752 
+ move under data/themes
@ofborg ofborg bot requested review from a user and tadfisher November 24, 2019 18:35
@romildo
Copy link
Contributor

romildo commented Nov 24, 2019 •
edited

I think that the GTK theming libraries (engines) should not be at pkgs/desktops. In my understanding this directory is for desktop environments, and not for single libraries.

Maybe they should go to pkgs/development/libraries, like the qvantum package. But I am not sure.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 24, 2019 •
edited

My reasoning was these engines are used for the theming of GTK-based desktop envs.
But I initially thought about dev/libraries too :) because well... it is libs. :)
I'll change that.

@romildo romildo self-requested a review November 25, 2019 02:12
@worldofpeace worldofpeace merged commit 5fcca4b into NixOS:master Nov 25, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 25, 2019 •
edited

I think we need to update https://nixos.org/nixpkgs/manual/#sec-hierarchy to include themes.
If you follow its instructions currently, I think most people are assuming it'll go under some place in misc.

@c0bw3b c0bw3b deleted the themes/kde branch November 25, 2019 15:07
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 25, 2019

Indeed, I'll try and prepare a PR for the manual

@c0bw3b c0bw3b mentioned this pull request Nov 27, 2019
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 28, 2019
@worldofpeace @dtzWill
Merge pull request NixOS#74060 from c0bw3b/themes/kde
672a278 
Regroup all themes under data/themes

(cherry picked from commit 5fcca4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo romildo approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @romildo @worldofpeace