Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault-bin: 1.1.3 -> 1.3.0 #74168

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Nov 25, 2019

Motivation for this change

1.1.3 is pretty old, lacks features.

Things done

Update vault-bin to 1.3.0

Added myself to the maintainer list, long overdue.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker @PsyanticY

@Br1ght0ne
Copy link
Member

@GrahamcOfBorg build vault-bin

@offlinehacker offlinehacker merged commit 2840544 into NixOS:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants