Fix preferences not opening when closed on macOS #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Nov 26, 2019
src/platform/guimac.mm
Outdated
| @@ -1409,6 +1409,7 @@ - (NSApplicationTerminateReply)applicationShouldTerminate:(NSApplication *)sende | |||
|
|
|||
| @implementation SSApplicationDelegate | |||
| - (IBAction)preferences:(id)sender { | |||
| SolveSpace::SS.GW.MenuView(SolveSpace::Command::SHOW_TEXT_WND); | |||
There was a problem hiding this comment.
This toggles the text window visibility.
There was a problem hiding this comment.
Oops, good to know haha, I will add a check around it to see if it's actually off
There was a problem hiding this comment.
Just do SS.GW.showTextWindow = true;
There was a problem hiding this comment.
But that would not update the checkmark if it's open or not, correct? e.g.:
if(SS.TW.window) SS.TW.window->SetVisible(SS.GW.showTextWindow);
showTextWndMenuItem->SetActive(SS.GW.showTextWindow);
There was a problem hiding this comment.
Oh yes, the horrible EnsureValidActives function. Go ahead with your plan.
Fix preferences not always opening on macOS
vespakoen
force-pushed
the
fix-preferences-opening-macos
branch
from
a5de704
to
537b737
Compare
|
Went ahead with the plan, hope it's fine now =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, when closing the preferences window, then clicking
Preferencesin the Menu, does not open the preferences window.This PR fixes that.