Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] Backport lib.getName fixes #74269

Merged
merged 2 commits into from Nov 26, 2019
Merged

[19.09] Backport lib.getName fixes #74269

merged 2 commits into from Nov 26, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Nov 26, 2019

Motivation for this change

Fix breakage caused by 9b090cc from #74057. This was discussed in #74264.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @Ericson2314 @jtojnar

worldofpeace and others added 2 commits November 26, 2019 15:40
@worldofpeace @talyz
update.nix: fix eval
776b456 
(cherry picked from commit e716e86)
@talyz
common-updater-scripts: Fix breakage
cc8bd61 
Fixes a bug introduced by 9b090cc
where the script fails to run if $attr.${versionKey} exists.

(cherry picked from commit 809768b)
@worldofpeace worldofpeace merged commit e056ef3 into NixOS:release-19.09 Nov 26, 2019
@worldofpeace
Copy link
Contributor

Thanks a lot @talyz ✨

@talyz talyz deleted the backport-getname-fixes branch June 16, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @worldofpeace