Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] openvswitch: 2.5.6 -> 2.5.9 and backports #74256

Closed

Conversation

kmcopper
Copy link
Contributor

Motivation for this change

Allows using a significantly newer version of openvswitch from the unstable channel. Bumps the release channel to bugfix 2.5.9 of openvswitch. I intend to maintain the stable branch along with the unstable branch along with netixx. I've tested this pretty extensively backporting the working patch to 19.09 and running it for maybe a week or so at this point and it works quite well both on the LTS channel and going from the LTS channel to the latest channel if it's selected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @netixx

netixx and others added 3 commits December 8, 2019 20:36
Openvswitch was upgraded to the latest
stable version (currenty 2.12.0). This remove ovs-monitor-ipsec
commands.

LTS version is still available using
`config.virtualisation.vswitch.package = pkgs.openvswitch-lts`
it has been upgraded to 2.5.6.

This commit is a split from the original PR NixOS#35127.

(cherry picked from commit e8e980e)
- tidy maintainer definition
- add kmcopper to maintainers
- use https for url fetch
- update lts to 2.5.9
- compile with openssl 1.1
- use https for homepage url
- use python3 in 2.12

(cherry picked from commit 2011aef)
Defaults openvswitch in release channel to using 2.5.9 the latest bugfix
release for that channel.
Allows optional selection of latest openvswitch release by
selecting virtualisation.vswitch.package = pkgs.openvswitch
@stale
Copy link

stale bot commented Jun 5, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2020
@doronbehar
Copy link
Contributor

I'm closing as the target branch is too old.

@doronbehar doronbehar closed this Sep 8, 2020
@kmcopper kmcopper deleted the r19.09-openvswitch-backport branch September 23, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants